Fix iOSBroadcastExtension always false after copyWith invoked #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected
When I pass
true
touseiOSBroadcastExtension
, the screen-share video track should invokegetDisplayMedia
with constraints containingdeviceId
set tobroadcast
.Actual
When I pass
true
touseiOSBroadcastExtension
, the screen-share video instead leaves constraintdeviceId
unset because a prior call toScreenShareCaptureOptions#copyWith
always setsuseiOSBroadcastExtension
to the default value offalse
.Fix
Added support to
ScreenShareCaptureOptions#copyWith
to preserve or overwrite the value ofuseiOSBroadcastExtension
.