Added extra_options parameter to OpenAI and Anthropic plugins #1210
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been added by default from the beginning, as we want to have access to all the parameters from the LLM APIs to be able to customize them. One use case would be observability and monitoring. I tried to integrate LiveKit with Langfuse, and I could pass the additional parameters needed to the completions call. This PR fixes that and let's other developers customize the LLM settings how they want, instead of waiting for each parameter to be added by the LK team (like parallel_tool_calls or tool_choice).
🦋 Changeset detectedLatest commit: 1495970 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
theomonnom
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been added by default from the beginning, as we want to have access to all the parameters from the LLM APIs to be able to customize them.
One use case would be observability and monitoring. I tried to integrate LiveKit with Langfuse, and I couldn't pass the additional parameters needed to the completions call.
This PR fixes that and lets other developers customize the LLM settings how they want, instead of waiting for each parameter to be added by the LK team (like the new parallel_tool_calls or tool_choice).