Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env metadata with git metadata #161

Merged
merged 1 commit into from
Aug 6, 2023
Merged

env metadata with git metadata #161

merged 1 commit into from
Aug 6, 2023

Conversation

royra
Copy link
Collaborator

@royra royra commented Aug 6, 2023

This is a

  • Bug fix
  • Feature
  • Doc improvement

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

  • I have used Preevy for a while and am familiar with the function it providers.

If this is a bug fix or feature:

  • I tested the proposed change on my cloud provider: GCE
  • I tested the proposed change on a local Kubernetes cluster.

@royra royra requested review from AssafKr and Yshayy August 6, 2023 08:19
Yshayy
Yshayy approved these changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@Yshayy Yshayy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Might worth adding API prefix for this and future APIs. (not necessarily in this PR)

Base automatically changed from cta-machine-info to main August 6, 2023 14:01
@royra royra merged commit abe1251 into main Aug 6, 2023
6 of 7 checks passed
@royra royra deleted the cta-git-metadata branch August 6, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yshayy Yshayy Yshayy approved these changes

@AssafKr AssafKr Awaiting requested review from AssafKr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@royra @Yshayy