Read and write syscalls may read less bytes than requested #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read/write syscalls may read/write less bytes then requied in the size, so on the larger block size lfs fuse library fails because read/write returns less bytes than required.
geky
reviewed
Dec 18, 2020
There was a problem hiding this comment.
Hi @lucckb, thanks for creating a PR!
The main thing is that this patch needs to match the style of the existing code. Squiggly brackets on same line of if statements, no spaces around conditions, spaces after if/while, space between pointer and type, no do-while loops (use while (true) with a break instead), and the ternary operators formatted as (res == 0) ? LFS_ERR_IO : -errno for consistency.
geky
reviewed
Dec 18, 2020
| wrb += res; | ||
| size -= res; | ||
| } | ||
| } while(0); |
There was a problem hiding this comment.
I may be missing something, but why does this do/while loop have 0 as a condition?
|
I've created an alternative PR that should fix this issue based on this PR: #54 Sorry about not bringing this one in and the late resolution. Thanks for the original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read/write syscalls may read/write less bytes then
required in the size argument, so when the larger block size
is passed to the library lfsfuse fails because read/write returns
less bytes than requested.