This repository has been archived by the owner on Sep 30, 2019. It is now read-only.
[134] AppSync Emulator - Implement conditionalCheckFailedHandler
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for PutItem, Strategy "Custom" needs more work
|
@asodeur tldr; Third party libs are fine but we try to be aware of their size and how they slow down the npm install (emulator has a ton of packages required already) |
| }, {}), | ||
| ) | ||
| ) | ||
| return Promise.resolve(oldValues); |
There was a problem hiding this comment.
Pretty sure you can just return oldValues here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements strategy "Reject" for PutItem.
Currently using
lodash.omitandlodash.isEqual. Not sure what the policy for including 3rd party libs is. Any preferred method for deep equality comparison?Strategy "Custom" would need considerably more work as it cannot be handled in
dynamodbSource.jsalone. The current implementation attaches the old values to theConditionalCheckFailedExceptionbefore re-throwing when strategy is "Custom".Partial implementation of #134