-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiple reporters at once + make reporters and github details configurable from config file, env variables, CLI flags #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
…onfig flags Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
… at once Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
reviewpad
bot
added
large
Pull request is large
enhancement
New feature or request
needs-review
Marks a pull request as waiting for review
labels
Mar 22, 2023
leodido
changed the title
feat: make reporters and github details configurable from config file, env variables, CLI flags
feat: support multiple reporters at once + make reporters and github details configurable from config file, env variables, CLI flags
Mar 22, 2023
…c flags/envvars/configs Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
…t on GitHub pull requests Signed-off-by: Leonardo Di Donato <[email protected]>
leodido
force-pushed
the
feat/reporters-from-env-and-config
branch
from
March 22, 2023 22:27
45b3fd9
to
f997710
Compare
fntlnz
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible work, flags are much more consistent now and the ability to have many reporters is just so needed. Thank you
LGTM
reviewpad
bot
removed
the
needs-review
Marks a pull request as waiting for review
label
Mar 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does many important things. Just to cite the 3 most important ones:
--reporter
flag and the GitHub flags related to it configurable via env and via config file #175).lstn.yaml
(or another) config filegh-pull-comment
(implemented)gh-pull-review
(TBD)gh-pull-check
(TBD report scan PR github check #167)What's missing?
[ ] Contextual validators on reporters and GitHub flags (eg.,(Contextual validation of reporter flags #172)--gh-pull-id
mandatory if--reporter
, etc. etc.)