Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple reporters at once + make reporters and github details configurable from config file, env variables, CLI flags #171

Merged
merged 17 commits into from
Mar 23, 2023

Conversation

leodido
Copy link
Contributor

@leodido leodido commented Mar 22, 2023

This PR does many important things. Just to cite the 3 most important ones:

What's missing?


leodido added 13 commits March 22, 2023 19:14
@leodido leodido requested a review from fntlnz as a code owner March 22, 2023 20:55
@reviewpad reviewpad bot added large Pull request is large enhancement New feature or request needs-review Marks a pull request as waiting for review labels Mar 22, 2023
@leodido leodido changed the title feat: make reporters and github details configurable from config file, env variables, CLI flags feat: support multiple reporters at once + make reporters and github details configurable from config file, env variables, CLI flags Mar 22, 2023
@leodido leodido force-pushed the feat/reporters-from-env-and-config branch from 45b3fd9 to f997710 Compare March 22, 2023 22:27
@leodido leodido self-assigned this Mar 22, 2023
Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work, flags are much more consistent now and the ability to have many reporters is just so needed. Thank you

LGTM

@reviewpad reviewpad bot removed the needs-review Marks a pull request as waiting for review label Mar 23, 2023
@leodido leodido merged commit cec1597 into main Mar 23, 2023
@leodido leodido deleted the feat/reporters-from-env-and-config branch March 23, 2023 11:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request large Pull request is large
Projects
None yet
2 participants