You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the feature or problem you’d like to solve
We want to have a PR github check when we analyse a PR via the lstn scan --reporter=github-pr-review reporter.
Proposed solution
How will it benefit CLI and its users?
the users will be able to see a progress directly in the PR while its being analysed
the progress is there even if the user is not using lstn via a github action but maybe locally or using another CI
How to do it:
Probably, adding a NotifyStatusChange or something similar to the reporter interface and calling it accordingly at start/end/error would do the trick. On the github-pr-review reporter we can just do the checks and we can ignore or implement it differently in future reporters.
Additional context
Right now, when the user uses our action the ugly status check is showed with a not so nice icon and text (basically the action's default)
We would ideally want to show something like this:
The text was updated successfully, but these errors were encountered:
Describe the feature or problem you’d like to solve
We want to have a PR github check when we analyse a PR via the
lstn scan --reporter=github-pr-review
reporter.Proposed solution
How will it benefit CLI and its users?
How to do it:
Probably, adding a
NotifyStatusChange
or something similar to the reporter interface and calling it accordingly at start/end/error would do the trick. On the github-pr-review reporter we can just do the checks and we can ignore or implement it differently in future reporters.Additional context
Right now, when the user uses our action the ugly status check is showed with a not so nice icon and text (basically the action's default)
We would ideally want to show something like this:
The text was updated successfully, but these errors were encountered: