refactor(pkg/validate): deprecate old validation mechanism

Signed-off-by: Leonardo Di Donato <[email protected]>
listendev · Mar 23, 2023 · b27cbfc · b27cbfc
1 parent 12cada0
commit b27cbfc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 46 deletions.
diff --git a/pkg/cmd/flags/config.go b/pkg/cmd/flags/config.go
@@ -40,12 +40,12 @@ type Registry struct {
 }
 
 type Pull struct {
-	ID int `name:"github pull request ID" flag:"gh-pull-id" desc:"set the GitHub pull request ID" validate:"required_if=Reporter github-pr-review" flagset:"Reporting" json:"gh-pull-id"`
+	ID int `name:"github pull request ID" flag:"gh-pull-id" desc:"set the GitHub pull request ID" flagset:"Reporting" json:"gh-pull-id"`
 }
 
 type GitHub struct {
-	Owner string `name:"github owner" flag:"gh-owner" desc:"set the GitHub owner name (org|user)" validate:"required_if=Reporter github-pr-review" flagset:"Reporting" json:"gh-owner"`
-	Repo  string `name:"github repository" flag:"gh-repo" desc:"set the GitHub repository name" validate:"required_if=Reporter github-pr-review" flagset:"Reporting" json:"gh-repo"`
+	Owner string `name:"github owner" flag:"gh-owner" desc:"set the GitHub owner name (org|user)" flagset:"Reporting" json:"gh-owner"`
+	Repo  string `name:"github repository" flag:"gh-repo" desc:"set the GitHub repository name" flagset:"Reporting" json:"gh-repo"`
 	Pull
 }
 

diff --git a/pkg/validate/reporter.go b/pkg/validate/reporter.go
diff --git a/pkg/validate/validate.go b/pkg/validate/validate.go
@@ -60,9 +60,6 @@ func init() {
 	if err := Singleton.RegisterValidation("version_constraint", isVersionConstraint); err != nil {
 		panic(err)
 	}
-	if err := Singleton.RegisterValidation("reporter", isReporterAvailable); err != nil {
-		panic(err)
-	}
 
 	Singleton.RegisterAlias("shasum", "len=40")
 	Singleton.RegisterAlias("mandatory", "required")