Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set server_id=1 for MySQL in integration tests #364

Merged
merged 2 commits into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
integration-tests:
name: Java ${{ matrix.java }}, MySQL ${{ matrix.mysql }}, MariaDB ${{ matrix.mariadb }}
runs-on: ubuntu-latest
timeout-minutes: 60
strategy:
matrix:
java: [8, 11, 17]
Expand Down Expand Up @@ -39,6 +40,7 @@ jobs:
snapshot-deploy:
name: Deploy Snapshot to Sonatype
runs-on: ubuntu-latest
timeout-minutes: 60
if: ${{ github.repository == 'liquibase/liquibase-percona' && github.ref == 'refs/heads/main' }}
needs: integration-tests
steps:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/prepare-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
setup:
name: Prepare Versions and Create Tag
runs-on: ubuntu-latest
timeout-minutes: 60
outputs:
extensionVersion: ${{ steps.determine_version.outputs.extensionVersion }}
liquibaseVersion: ${{ steps.determine_version.outputs.liquibaseVersion }}
Expand Down Expand Up @@ -70,6 +71,7 @@ jobs:
needs: setup
name: "Build and Unit Test"
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -106,6 +108,7 @@ jobs:
needs: setup
name: Java ${{ matrix.java }}, MySQL ${{ matrix.mysql }}, MariaDB ${{ matrix.mariadb }}
runs-on: ubuntu-latest
timeout-minutes: 60
strategy:
matrix:
java: [8, 11, 17]
Expand Down Expand Up @@ -141,6 +144,7 @@ jobs:
draft-release:
needs: [setup, build, integration-tests]
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
integration-test:
name: Java ${{ matrix.java }}
runs-on: ubuntu-latest
timeout-minutes: 60
strategy:
matrix:
java: [8]
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release-published.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
jobs:
release:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v4

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/update-changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
jobs:
update-changelog:
runs-on: ubuntu-latest
timeout-minutes: 60

steps:
- uses: actions/checkout@v4
Expand Down
8 changes: 8 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,14 @@
<env>
<MYSQL_ROOT_PASSWORD>${config_password}</MYSQL_ROOT_PASSWORD>
</env>
<cmd>
<exec>
<!-- set server_id to 1 for mysql 5.7 and percona-toolkit 3.5.5, see https://jira.percona.com/browse/PT-2268
Note: mysql 8.0 and mariadb use by default server_id=1, only mysql 5.7 uses server_id=0 as default.
-->
<arg>--server-id=1</arg>
</exec>
</cmd>
<containerNamePattern>%a</containerNamePattern>
<network>
<mode>bridge</mode>
Expand Down