Implement multi-schema support #727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-kleber-avelios
requested a review
from filipelautert
as a code owner
philipp-kleber-avelios
temporarily deployed
to
external
GitHub Actions
Inactive
MalloD12
reviewed
Dec 9, 2024
src/main/java/liquibase/ext/hibernate/database/HibernateDatabase.java
Outdated
Show resolved
Hide resolved
filipelautert
force-pushed
the
multi-schema-support
branch
from
7effe3b to
0385016
Compare
filipelautert
temporarily deployed
to
external
GitHub Actions
Inactive
MalloD12
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Approved.
Besides the minor comment I posted this looks good to me. Thank you, @philipp-kleber-avelios for contributing with this PR.
Daniel.
philipp-kleber-avelios
temporarily deployed
to
external
GitHub Actions
Inactive
filipelautert
requested changes
Dec 12, 2024
src/main/java/liquibase/ext/hibernate/snapshot/SequenceSnapshotGenerator.java
Outdated
Show resolved
Hide resolved
philipp-kleber-avelios
requested a deployment
to
external
GitHub Actions
Waiting
filipelautert
force-pushed
the
multi-schema-support
branch
from
21227fc to
6d8764b
Compare
filipelautert
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Thanks for the improvement @philipp-kleber-avelios !
@tati-qalified if you need any ideas on how to test it please let me know.
rberezen
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are an initial experiment to resolve issue #248, by allowing multiple schemas during the snapshot.
I added a new test
HibernateMultiSchemaTest.java, which currently only checks the exit code of such a multi-schemadiffChangelogcommand.If somebody could review the code and maybe give their input if the changes are sufficient or if additional ones are required, that would be great, thanks!.