[DAT-18844] resolved some sonar issues #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KushnirykOleh
commented
Oct 31, 2024
| @@ -16,11 +15,6 @@ public class AlterTablePropertiesChangeDatabricks extends AbstractAlterPropertie | |||
| private static final String CHANGE_TYPE_SUBJECT = "Table"; | |||
| private String tableName; | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
AbstractAlterPropertiesChangeDatabricks already has supports() method that check DatabricksDatabase
SvampX
approved these changes
Oct 31, 2024
| @@ -106,20 +103,17 @@ public Sql[] generateSql(InsertOrUpdateStatement insertOrUpdateStatement, Databa | |||
| completeSql.append(updateStatement); | |||
|
|
|||
| // Add insert statement to MERGE if not ONLY an update statement | |||
| if (!insertOrUpdateStatement.getOnlyUpdate()) { | |||
| if (Boolean.FALSE.equals(insertOrUpdateStatement.getOnlyUpdate())) { | |||
There was a problem hiding this comment.
Was it a complain because of autoboxing?
I have a bunch of similar checks in other places, but with primitive type.
There was a problem hiding this comment.
kinda, it complains about auto-Unboxing, saying in case of getOnlyUpdate() is null we'll get NPE
|
LGTM! |
filipelautert
approved these changes
Oct 31, 2024
KushnirykOleh
force-pushed
the
DAT-18844
branch
from
3435072 to
efbc554
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.