Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAT-18791] Support for Identity info in snapshotting #205

Merged
merged 5 commits into from
Nov 18, 2024
Merged

[DAT-18791] Support for Identity info in snapshotting #205

merged 5 commits into from
Nov 18, 2024

Conversation

KushnirykOleh
Copy link
Contributor

@KushnirykOleh KushnirykOleh commented Oct 29, 2024 •
edited
Loading

refactored column snapshot generator, added test

@KushnirykOleh KushnirykOleh requested a review from SvampX October 29, 2024 14:59
filipelautert
filipelautert approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pending @SvampX comments.

@KushnirykOleh KushnirykOleh changed the title [DAT-18790] refactored column snapshot generator, added test [DAT-18791] refactored column snapshot generator, added test Oct 31, 2024
@KushnirykOleh KushnirykOleh changed the title [DAT-18791] refactored column snapshot generator, added test [DAT-18791] Support for Identity info in snapshotting Oct 31, 2024
Base automatically changed from DAT-18790 to main November 18, 2024 12:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@KushnirykOleh KushnirykOleh merged commit 8e00a02 into main Nov 18, 2024
17 checks passed
@KushnirykOleh KushnirykOleh deleted the DAT-18791 branch November 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvampX SvampX SvampX approved these changes

@filipelautert filipelautert filipelautert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KushnirykOleh @filipelautert @SvampX @PavloTytarchuk