Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of final image by removing apt caches #21

Merged
merged 11 commits into from
Oct 27, 2020

Conversation

dhwanitsshah
Copy link
Contributor

No description provided.

@r2-lf
Copy link
Contributor

r2-lf commented Jul 28, 2020

Thanks @dhwanitsshah! What's the size savings we get with those changes? Also, can you rebase? Thanks!

@dhwanitsshah
Copy link
Contributor Author

dhwanitsshah commented Jul 29, 2020

Thanks @dhwanitsshah! What's the size savings we get with those changes? Also, can you rebase? Thanks!

That saved about 17 MB!

The first image(apt_clean tag) is built after removing apt cache while the second image (without_apt_clean tag) was built without deleting apt cache.

image

Hope this helps :)

@r2-lf
Copy link
Contributor

r2-lf commented Jul 29, 2020

Cool, @dhwanitsshah . Thanks a ton.

We've gotten a lot of heat from the users about the rate at which we are changing these images. Cool if we wait a while on this?

@dhwanitsshah
Copy link
Contributor Author

Thanks @r2liquibase, sure we can wait for this until next release/update cycle.

@r2-lf r2-lf requested a review from jgkoops September 10, 2020 15:20
@r2-lf
Copy link
Contributor

r2-lf commented Sep 10, 2020

Hi, @dhwanitsshah ! Do you mind rebasing this. We made some changes in main that are causing a merge conflict. Thanks!

@dhwanitsshah
Copy link
Contributor Author

@r2liquibase , @jgkoops - I have rebased my branch with the new changes by resolving the conflicts.. could you please review and merge this pull request?

Copy link

@jgkoops jgkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK w/ me

@dhwanitsshah
Copy link
Contributor Author

Thanks @jgkoops

@dhwanitsshah
Copy link
Contributor Author

@r2liquibase ,@jgkoops - Hi, may I know when this pull request will be merged ?

@r2-lf
Copy link
Contributor

r2-lf commented Oct 19, 2020

Thank you @jgkoops and @dhwanitsshah . We do have a small issue with the PR: Docker doesn't want us to use the CMD at the end to call --help by default. We're attempting to get this accepted as an official image from Docker Hub.

Here's the PR: docker-library/official-images#8409.

@dhwanitsshah
Copy link
Contributor Author

Great thanks @r2liquibase for the update. Sure, will provide any refactor if need be once the thing gets finalized. :)

@r2-lf
Copy link
Contributor

r2-lf commented Oct 21, 2020

I appreicate you @dhwanitsshah ! Feel free to comment on that PR and ask why they haven't accepted it!!!!

@dhwanitsshah
Copy link
Contributor Author

Thanks @r2liquibase, have asked them if the changes are good to be merged.

… cached package archive feature is disabled.
@nvoxland nvoxland merged commit c2e91af into liquibase:main Oct 27, 2020
@r2-lf
Copy link
Contributor

r2-lf commented Oct 27, 2020

Thank you @dhwanitsshah !

@dhwanitsshah
Copy link
Contributor Author

Thank you @dhwanitsshah !

Thanks @r2liquibase and @nvoxland for PR review & merge! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants