-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size of final image by removing apt caches #21
Conversation
Thanks @dhwanitsshah! What's the size savings we get with those changes? Also, can you rebase? Thanks! |
That saved about 17 MB! The first image(apt_clean tag) is built after removing apt cache while the second image (without_apt_clean tag) was built without deleting apt cache. Hope this helps :) |
Cool, @dhwanitsshah . Thanks a ton. We've gotten a lot of heat from the users about the rate at which we are changing these images. Cool if we wait a while on this? |
Thanks @r2liquibase, sure we can wait for this until next release/update cycle. |
Hi, @dhwanitsshah ! Do you mind rebasing this. We made some changes in |
@r2liquibase , @jgkoops - I have rebased my branch with the new changes by resolving the conflicts.. could you please review and merge this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK w/ me
Thanks @jgkoops |
@r2liquibase ,@jgkoops - Hi, may I know when this pull request will be merged ? |
Thank you @jgkoops and @dhwanitsshah . We do have a small issue with the PR: Docker doesn't want us to use the CMD at the end to call --help by default. We're attempting to get this accepted as an official image from Docker Hub. Here's the PR: docker-library/official-images#8409. |
Great thanks @r2liquibase for the update. Sure, will provide any refactor if need be once the thing gets finalized. :) |
I appreicate you @dhwanitsshah ! Feel free to comment on that PR and ask why they haven't accepted it!!!! |
Thanks @r2liquibase, have asked them if the changes are good to be merged. |
… cached package archive feature is disabled.
Thank you @dhwanitsshah ! |
Thanks @r2liquibase and @nvoxland for PR review & merge! 👍 |
No description provided.