Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IPAM]: Refactor IP controller #2816

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[IPAM]: Refactor IP controller #2816

merged 1 commit into from
Nov 21, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Nov 14, 2024

Description

This PR refactors the IPcontroller to support the new IPAM

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 added the kind/cleanup Refactoring code label Nov 14, 2024
@fra98 fra98 changed the title [IPAM]: IP controller [IPAM]: Refactor IP controller Nov 14, 2024
@fra98
Copy link
Member Author

fra98 commented Nov 14, 2024

/build

@fra98 fra98 marked this pull request as ready for review November 18, 2024 14:39
@fra98 fra98 force-pushed the frt/ip-controller branch 4 times, most recently from 9517b5e to 29ea1fe Compare November 18, 2024 16:13
@fra98
Copy link
Member Author

fra98 commented Nov 19, 2024

/build

@fra98
Copy link
Member Author

fra98 commented Nov 19, 2024

/build

cheina97
cheina97 reviewed Nov 21, 2024
View reviewed changes
pkg/ipam/utils/doc.go Outdated Show resolved Hide resolved
@fra98 fra98 merged commit 137a743 into liqotech:ipam Nov 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 left review comments

@aleoli aleoli aleoli approved these changes

@claudiolor claudiolor Awaiting requested review from claudiolor

Assignees
No one assigned
Labels
kind/cleanup Refactoring code size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fra98 @adamjensenbot @cheina97 @aleoli