[Feat] Add nodePort and loadbalancerIPAddress as optional fields in WG gateway template #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @claudiolor. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
claudiolor
changed the title
|
/build |
claudiolor
force-pushed
the
clo/template-optional-values
branch
2 times, most recently
from
0ab99ed
to
342818d
Compare
fra98
approved these changes
Nov 4, 2024
|
/rebase test=true |
This patch introduces a new syntax for the templates allowing the usage of optional values: when a field in a template starts with ? (question mark) and it contains a variable, that field is rendered in the template only if that variable has a value.
This patch adds nodePort and loadbalancerIPAddress as optional fields in the template of the Wireguard gateway server service. This allows to specify those fields in the GatewayServer configuration without asking the user to manually edit the template.
adamjensenbot
force-pushed
the
clo/template-optional-values
branch
from
342818d
to
a5f8712
Compare
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two features:
nodePortandloadbalancerIPAddressare now present by default in the WG gateway server template, allowing the user to specify them without the need to manually add them in the template.How Has This Been Tested?
Test suite has been provided