Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: liqoctl cluster labels and API server addr override collection #2781

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

claudiolor
Copy link
Contributor

Description

The liqoctl info command returns a waning everytime:

  • the Liqo intallation has no cluster labels: but this is acceptable
  • the K8s api server address is overwritten: as no API server address is found. The info command does not handle the case in which there is an override of the K8s API server address, so the output does not show the correct address.

This PR fixes this issue by not issuing any warning when labels are not found and by checking on the controller-manager if an override of the K8s API server has been configured.

@adamjensenbot
Copy link
Collaborator

Hi @claudiolor. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 added the kind/bug Something isn't working label Oct 22, 2024
@fra98
Copy link
Member

fra98 commented Oct 24, 2024

/rebase test=true

@fra98
Copy link
Member

fra98 commented Oct 25, 2024

/test

@claudiolor
Copy link
Contributor Author

/test

@cheina97
Copy link
Member

/rebase test=true

@fra98
Copy link
Member

fra98 commented Nov 18, 2024

/rebase test=true

@cheina97 cheina97 merged commit 5201cd5 into liqotech:master Nov 18, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants