This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Enable email-comments #521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated sinks for better translation possibilities.
removed thread lock
Updated debris - function. If more than three breaks follow each other they will be no longer shrinked to two breaks.
in the last two minutes. This could happen if the same inbox is watched multiple times so the program gets multiple parse commands for the same email.
between revisions in DB and recently parsed emails
|
Very interesting, thanks for submitting! (There won't be a review from my side in the next 2 weeks due to holidays) |
|
|
||
| sec_token = result.group("sectoken") | ||
|
|
||
| secrets = config.get("adhocracy.crypto.secret") |
There was a problem hiding this comment.
This part should use the new adhocracy.crypto functions instead of reimplementing them
There was a problem hiding this comment.
Didn't use the adhocracy.crypto functions to assure that the local part of the email-address is short enough (sinks.py). Will look deeper into that new functions - maybe there is a way to assure that with usage of external functions which could be changed to a safer (and longer) hash.
comment_exists-function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This program enables comment-replies via email in adhocracy.
Features: