This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Allows the user to login only via email without reseting the password #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option "I have no password" the user is now able to login via email instead of requesting a new password. routing.py - added path to the "emaillogin" action in the user controller user.py - added perform_email_login method to the user controller.If the adhocracy.login_style is set to alternate it sends an email with an login link to the user - Added emaillogin method to catch EmailLoginRepozeWho errors Authentication.py - Changed the Path action path to perform_email_login - Added Email EmailLoginRepozeWho created emaillogin.py - Added EmailLoginRepozeWho controller created login_email.html - Informs the user that he got a new email
phihag
added a commit
that referenced
this pull request
Jun 16, 2013
This simplifies the cookie session implementation and also #426 and hhucn/adhocracy.hhu_theme#341 .
| except (TypeError, ValueError): | ||
| return False | ||
| correct_value = create_hash(email, user_time, config) | ||
| if (user_hash == correct_value) and (time_dif < 3600): |
There was a problem hiding this comment.
Instead of 3600, we should use a configuration option here, and default it to 3600.
|
We should require |
| absolute=True) | ||
|
|
||
|
|
||
| def create_token(email, config): |
There was a problem hiding this comment.
This should definitely use the new crypto functions.
added 2 commits
July 30, 2013 12:22
| @@ -34,7 +34,7 @@ def get_secret(config=config, key=None): | |||
| for k in search_keys: | |||
| if config.get(k): | |||
| assert config[k] != 'autogenerated' | |||
| res = config[k] | |||
| res = config.get(k) | |||
| @@ -388,6 +388,9 @@ adhocracy.static_index_path = index | |||
| # Ask the user for email and then password, instead of form + links | |||
| # adhocracy.login_style = alternate | |||
|
|
|||
| # Determines how long an email login link is valid in seconds | |||
| 3600 | |||
There was a problem hiding this comment.
Before merging, we need to change this line, btw.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the loginstyle is set to alternate and the user clicks choses option "I have no password" the user is now able to login via email instead of requesting a new password.
routing.py
user.py
Authentication.py
created emaillogin.py
created login_email.html