Merge pull request #847 from xi/feature-category-link

category links in sidebars
liqd · Apr 7, 2014 · c80c60f · c80c60f
2 parents 79a8e5f + 3ff3ad9
commit c80c60f
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/src/adhocracy/lib/helpers/__init__.py b/src/adhocracy/lib/helpers/__init__.py
@@ -254,6 +254,9 @@ def entity_url(entity, **kwargs):
         return treatment.url(entity, **kwargs)
     elif isinstance(entity, model.Message):
         return message.url(entity, **kwargs)
+    elif (isinstance(entity, model.CategoryBadge) and c.instance is not None
+          and c.instance.display_category_pages):
+        return category.url(entity, **kwargs)
     raise ValueError("No URL maker for: %s" % repr(entity))
 
 

diff --git a/src/adhocracy/templates/components.html b/src/adhocracy/templates/components.html
@@ -491,3 +491,12 @@
         ${tables}
     </div>
 </%def>
+
+
+<%def name="category_link(category)">
+    %if c.instance is not None and c.instance.display_category_pages:
+    <a href="${h.entity_url(category)}">${category}</a>
+    %else:
+    ${category}
+    %endif
+</%def>
diff --git a/src/adhocracy/templates/page/show.html b/src/adhocracy/templates/page/show.html
@@ -66,7 +66,7 @@ <h6>${_('Last Activity')}</h6>
         <h6>${_('Category')}</h6>
         <p>
             %if c.page.category:
-            ${c.page.category}
+            ${components.category_link(c.page.category)}
             %else:
             ${_("This page is not assigned to any category")}
             %endif

diff --git a/src/adhocracy/templates/proposal/show.html b/src/adhocracy/templates/proposal/show.html
@@ -238,7 +238,7 @@ <h6>${_('Last Activity')}</h6>
         <h6>${_('Category')}</h6>
         <p>
           %if c.proposal.category:
-          ${c.proposal.category}
+          ${components.category_link(c.proposal.category)}
           %else:
           ${_("This proposal is not assigned to any category")}
           %endif