Skip to content

Commit

Permalink
Rename busybox_HTTPD to busybox-httpd and clarify new CMD call
Browse files Browse the repository at this point in the history
  • Loading branch information
lipanski committed May 7, 2024
1 parent d1d7862 commit 295afd8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ EXPOSE 3000
COPY --from=builder /etc/passwd /etc/passwd

# Copy the static binary
COPY --from=builder /busybox/busybox_HTTPD /busybox_HTTPD
COPY --from=builder /busybox/busybox_HTTPD /busybox-httpd

# Use our non-root user
USER static
Expand All @@ -50,4 +50,4 @@ COPY httpd.conf .
# COPY . .

# Run busybox httpd
CMD ["/busybox_HTTPD", "-f", "-v", "-p", "3000", "-c", "httpd.conf"]
CMD ["/busybox-httpd", "-f", "-v", "-p", "3000", "-c", "httpd.conf"]
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ FROM lipanski/docker-static-website:latest
# Copy your static files
COPY . .

CMD ["/busybox", "httpd", "-f", "-v", "-p", "3000", "-c", "httpd.conf"]
CMD ["/busybox-httpd", "-f", "-v", "-p", "3000", "-c", "httpd.conf"]
```

**NOTE:** Sending a `TERM` signal to your TTY running the container won't get propagated due to how busybox is built. Instead you can call `docker stop` (or `docker kill` if can't wait 15 seconds). Alternatively you can run the container with `docker run -it --rm --init` which will propagate signals to the process correctly.
Expand Down

0 comments on commit 295afd8

Please sign in to comment.