fix: update target path naming hierarchy TDE-955 #845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The target path name formatting is inconsistent with the final decisions in the naming.md
It is now expected that the event name will be included in the
geographic_description
field as well.Sometimes the event name includes the location (
Top of the South Floods
) and sometimes it does not (Cyclone Gabrielle
) Therefore it is difficult to determine whether to merge theevent_name
with theregion
/geographic_description
.It is also preferable to keep the
event_name
consistent across all imagery so that datasets can be filtered by events for example the Cyclone Gabrielle imagery in Hawkes Bay, Gisborne & the North Island should all haveevent_name=Cyclone Gabrielle
.examples:
inputs:
region=Hawke's Bay
gd= Hawke's Bay Cyclone Gabrielle
event_name=Cyclone Gabrielle
paths:
s3://nz-imagery/hawkes-bay/hawkes-bay-cyclone-gabrielle_2023_0.1m/
inputs:
region=Nelson
gd= Top of the South Floods
event_name=Top of the South Floods
paths:
s3://nz-imagery/nelson/top-of-the-south-floods_2023_0.1m/
inputs:
region=Auckland
paths:
s3://nz-imagery/auckland/auckland_2023_0.1m/
inputs:
region=Wellington
gd=Upper Hutt
paths:
s3://nz-imagery/wellington/upper-hutt_2023_0.1m/
Modification
name portion of the target path changed from:
to
Checklist
If not applicable, provide explanation of why.
- [ ] Docs updated- n/a