refactor: Remove dead code (#804)

#### Motivation

Cleans up miscellaneous issues found by JetBrains IDEA.

#### Modification

- Remove unreferenced example code
- Remove unused variables, types, classes
- Import type rather than relying on UMD global variable
- Wait for writes to finish

#### Checklist

None of these are applicable. This is just a cleanup.

- [ ] Tests updated
- [ ] Docs updated
- [ ] Issue linked in Title

src/commands/basemaps-mapsheet/create-mapsheet.ts

@@ -86,7 +86,7 @@ export const basemapsCreateMapSheet = command({
     const mem = ConfigProviderMemory.fromJson(configJson);
 
     const rest = fgb.deserialize(buf) as FeatureCollection;
-    fsa.write('features.json', JSON.stringify(rest));
+    const featuresWritePromise = fsa.write('features.json', JSON.stringify(rest));
 
     const aerial = await mem.TileSet.get('ts_aerial');
     if (aerial == null) throw new Error('Invalid config file.');
@@ -95,7 +95,9 @@ export const basemapsCreateMapSheet = command({
     const outputs = await createMapSheet(aerial, mem, rest, include, exclude);
 
     logger.info({ outputPath }, 'MapSheet:WriteOutput');
-    fsa.write(outputPath, JSON.stringify(outputs, null, 2));
+    const outputWritePromise = fsa.write(outputPath, JSON.stringify(outputs, null, 2));
+
+    await Promise.all([featuresWritePromise, outputWritePromise]);
   },
 });
 

src/commands/format/pretty.print.ts

@@ -75,10 +75,8 @@ export async function formatFile(path: string, target = ''): Promise<void> {
  * @returns the stringify JSON pretty printed
  */
 export async function prettyPrint(jsonStr: string, config: prettier.Options): Promise<string> {
-  const formatted = await prettier.format(jsonStr, {
+  return await prettier.format(jsonStr, {
     ...config,
     parser: 'json',
   });
-
-  return formatted;
 }

src/commands/tileindex-validate/__test__/tileindex.validate.test.ts

@@ -3,6 +3,7 @@ import { before, beforeEach, describe, it } from 'node:test';
 
 import { fsa } from '@chunkd/fs';
 import { FsMemory } from '@chunkd/source-memory';
+import { FeatureCollection } from 'geojson';
 
 import { MapSheet } from '../../../utils/mapsheet.js';
 import {
@@ -115,7 +116,7 @@ describe('validate', () => {
     assert.equal(stub.mock.callCount(), 1);
     assert.deepEqual(stub.mock.calls[0]?.arguments[0], ['s3://test']);
 
-    const outputFileList: GeoJSON.FeatureCollection = await fsa.readJson('/tmp/tile-index-validate/output.geojson');
+    const outputFileList: FeatureCollection = await fsa.readJson('/tmp/tile-index-validate/output.geojson');
     assert.equal(outputFileList.features.length, 1);
     const firstFeature = outputFileList.features[0];
     assert.equal(firstFeature?.properties?.['tileName'], 'AS21_1000_0101');

src/commands/tileindex-validate/tileindex.validate.ts

@@ -57,10 +57,6 @@ export const TiffLoader = {
   },
 };
 
-export interface FileList {
-  tileName: string;
-  uris: string[];
-}
 /**
  * Validate list of tiffs match a LINZ Mapsheet tile index
  *

src/utils/actions.ts

@@ -1,5 +1,3 @@
-export type Actions = ActionCopy;
-
 export interface ActionCopy {
   action: 'copy';
   parameters: {

src/utils/github.ts

@@ -4,12 +4,6 @@ import { Api } from '@octokit/plugin-rest-endpoint-methods/dist-types/types.js';
 
 import { logger } from '../log.js';
 
-export interface Job {
-  imagery: string;
-  tileMatrix: string;
-  content: string;
-}
-
 export interface Blob {
   path: string;
   mode: '100644';
@@ -34,7 +28,6 @@ export class GithubApi {
   }
 
   isOk = (s: number): boolean => s >= 200 && s <= 299;
-  isNotFound = (s: number): boolean => s === 404;
   toRef = (branch: string): string => `heads/${branch}`;
 
   /**