release script simplifications #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might as well since we only ever release one module at a time with this script.
No longer hooked into anything so let's not pretend we have it.
These haven't been needed in decades. Where a string may be empty use quotes, otherwise let's switch string comparisons to just that. And where we check for empty/nonempty use -z/-n.
|
Tested-by: Ping Cheng [email protected] It worked for me. Thank you Peter! |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two cleanups and one simplification: we don't need to enforce the extra dot for the module:
release.sh .. We only ever use this script on one repo anyway, so let's imply that.