-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data: add the XP-Pen ACK05 Remote, take 2 #788
Conversation
ftr, g-s-d is mostly dead and doesn't do much anymore, virtually all the code is now in gnome-control-center (read-only stuff) and mutter. but yes, the dials won't work in GNOME yet because the wayland protocol is not upstream which means mutter etc. cannot use it. |
feb8bca
to
bf7df65
Compare
Work in progress, I'm eventually going to show the dial in the UI :) |
Great news! Thanks a lot for working on this. Currently the plan is to not merge things here and in udev-hid-bpf as long as things are not ready in KDE/Gnome. Simply because otherwise we are just removing the somehow useful Ctrl+/Ctrl- default output of the Diai and will break things for users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bentisss: can you rebase this one please. I don't see why we cannot already merge this one - any .tablet
file for this device will look the same, regardless of whether BPF is involved of not.
bf7df65
to
ce40d5d
Compare
OK, rebased, fixed the tablet file, force pushed and removing draft status |
merged, thanks |
Taking over #777, because I have the HW locally and could do some more testing.
This has a couple of
clean_svg.py
fixes, and the SVG from @Deevad (fixed by me).The dial still doesn't work properly in the overlay, so I wonder if the problem is not in gnome-settings-daemon. KDE only shows the buttons, not the dial.
I also tried adding the "modes", but it seems that they are not recognized by default by g-s-d (is this because there is no LEDs on the device and then non sysfs for them?)
Also, still no sysinfo, this is pretty much pre-development at thios stage, and we need to figure out if we are happy with the button mapping first.