Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: add the XP-Pen ACK05 Remote, take 2 #788

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

bentiss
Copy link
Contributor

@bentiss bentiss commented Oct 15, 2024

Taking over #777, because I have the HW locally and could do some more testing.

This has a couple of clean_svg.py fixes, and the SVG from @Deevad (fixed by me).

The dial still doesn't work properly in the overlay, so I wonder if the problem is not in gnome-settings-daemon. KDE only shows the buttons, not the dial.

I also tried adding the "modes", but it seems that they are not recognized by default by g-s-d (is this because there is no LEDs on the device and then non sysfs for them?)

Also, still no sysinfo, this is pretty much pre-development at thios stage, and we need to figure out if we are happy with the button mapping first.

@bentiss bentiss marked this pull request as draft October 15, 2024 16:38
tools/clean_svg.py Outdated Show resolved Hide resolved
data/xp-pen-ack05-remote.tablet Outdated Show resolved Hide resolved
@whot
Copy link
Member

whot commented Oct 16, 2024

so I wonder if the problem is not in gnome-settings-daemon.

ftr, g-s-d is mostly dead and doesn't do much anymore, virtually all the code is now in gnome-control-center (read-only stuff) and mutter.

but yes, the dials won't work in GNOME yet because the wayland protocol is not upstream which means mutter etc. cannot use it.

@bentiss bentiss force-pushed the wip/xp-pen-remote branch 3 times, most recently from feb8bca to bf7df65 Compare October 16, 2024 14:20
@redstrate
Copy link
Contributor

The dial still doesn't work properly in the overlay, so I wonder if the problem is not in gnome-settings-daemon. KDE only shows the buttons, not the dial.

Work in progress, I'm eventually going to show the dial in the UI :)

@bentiss
Copy link
Contributor Author

bentiss commented Oct 17, 2024

Work in progress, I'm eventually going to show the dial in the UI :)

Great news! Thanks a lot for working on this.

Currently the plan is to not merge things here and in udev-hid-bpf as long as things are not ready in KDE/Gnome. Simply because otherwise we are just removing the somehow useful Ctrl+/Ctrl- default output of the Diai and will break things for users.

@whot whot mentioned this pull request Oct 21, 2024
Copy link
Member

@whot whot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bentisss: can you rebase this one please. I don't see why we cannot already merge this one - any .tablet file for this device will look the same, regardless of whether BPF is involved of not.

data/xp-pen-ack05-remote.tablet Outdated Show resolved Hide resolved
@bentiss
Copy link
Contributor Author

bentiss commented Oct 22, 2024

OK, rebased, fixed the tablet file, force pushed and removing draft status

@bentiss bentiss marked this pull request as ready for review October 22, 2024 06:40
@whot whot merged commit 95121fb into linuxwacom:master Oct 28, 2024
15 checks passed
@whot
Copy link
Member

whot commented Oct 28, 2024

merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants