-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Wacom Movink #673
Conversation
This is a complete new layout for Wacom Movink Signed-off-by: Tatsunosuke Tobita <[email protected]>
This is a new tablet file for Wacom Movink Signed-off-by: Tatsunosuke Tobita <[email protected]>
This changes support Wacom One pen on Wacom Movink. Signed-off-by: Tatsunosuke Tobita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick PR - a few questions but otherwise this is almost ready.
data/movink.tablet
Outdated
Left=A;C | ||
Right=B;C |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't have one button in two locations but based on the drawing this should be Top=C
, right?
Also, after looking at some marketing pictures: are those real buttons or emulated by the driver (in userspace)? or rather: do we get those events under linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top=C, right?
I'll work on this, thanks!
There are two buttons on each sides, so I thought they should be the sides.
"Tpo=C" makes much sense.
Yes, one of the physical buttons can be assigned for an express key, but it also can be other functionalities than the express key; one of them is "Touch on/off".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be assigned for an express key,
so these are software/firmware controlled buttons? that's going to be ... interesting, libwacom doesn't have a good way to express these for now.
Might be best to add a comment in the file here and then figure out how to really handle this later when we have the consumers (e.g. mutter + gnome-control-center) actually wanting deal with these buttons.
Co-authored-by: Peter Hutterer <[email protected]>
Hi, there. I'm a bot and have been asked to have a look at this. Please run the sysinfo script from https://github.com/linuxwacom/wacom-hid-descriptors and The
A See also https://github.com/linuxwacom/libwacom/wiki/Adding-a-new-device This is an automated comment created by a bot. Responding to the bot or mentioning it won't have any effect. |
data/movink.tablet
Outdated
Left=A;C | ||
Right=B;C |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be assigned for an express key,
so these are software/firmware controlled buttons? that's going to be ... interesting, libwacom doesn't have a good way to express these for now.
Might be best to add a comment in the file here and then figure out how to really handle this later when we have the consumers (e.g. mutter + gnome-control-center) actually wanting deal with these buttons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. CI still fails so at least two changes are still needed - please make sure to run meson test -C builddir
locally, that'll run (most of) the test suite locally so it'll speed up finding the various nitpicks my human eyes won't see :)
Buttons line added for the UD pen eraser, 0x1000A
Modified to add information of sysinfo and required changed by the review
I modified the codes and updated them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the eraser parsing fails, fixing that should fix the CI
All good now, let's get this merged! Thanks heaps for the effort |
Hi, there. I'm a bot and have been asked to have a look at this. Thanks for providing the sysinfo. Someone will be along shortly to review the PR. This is an automated comment created by a bot. Responding to the bot or mentioning it won't have any effect. |
Signed-off-by: Tatsunosuke Tobita <[email protected]> (cherry picked from commit 03a9a24)
Signed-off-by: Tatsunosuke Tobita <[email protected]> (cherry picked from commit 03a9a24)
Those commits are ready for Wacom Movink announced yesterday.