test: remove the requirement for a Layout file #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we required a layout file for any tablet with pad buttons. This somewhat prevents us from adding tablet files for unknown tablets where we can get most of the information from external sources, e.g. see linuxwacom#659. As a result we're missing support for these tablets altogether when we could have at least partial support. Let's drop this requirement in our tests, users who want their tablet working properly can submit layout files.
whot
force-pushed
the
wip/dont-require-layouts
branch
from
dbac192 to
81fc21f
Compare
There was a problem hiding this comment.
Mmmm what if I prefix the files added in #659 with unverified- and we only skip this test in that case?
Sorry for the CI failures, I'm not familiar with the tests yet.
Nah, too much effort I reckon. Might as well punt some of that to those that have the tablets :) |
|
Going to merge this, #659 as a bigger and more beneficial long-term impact than disabling the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we required a layout file for any tablet with pad buttons. This somewhat prevents us from adding tablet files for unknown tablets where we can get most of the information from external sources, e.g. see #659. As a result we're missing support for these tablets altogether when we could have at least partial support.
Let's drop this requirement in our tests, users who want their tablet working properly can submit layout files.
cc @JoseExposito