Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: Add Wacom HID-5362 #617

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

olivgat
Copy link
Contributor

@olivgat olivgat commented Dec 17, 2023

Add laptop Lenovo Yoga 7 which uses Wacom HID 5362 Pen and Wacom HID 5362 Finger (vid: '0x056a', pid: '0x5362')

@whot whot added the sysinfo needed Used to indicate sysinfo is missing from the PR label Dec 17, 2023
Copy link

Hi, there. I'm a bot and have been asked to have a look at this.

Please run the sysinfo script from https://github.com/linuxwacom/wacom-hid-descriptors and
file a new issue in that repo with the resulting sysinfo tarball. The README in that repo
has more information and instructions.

The .tablet files in this PR should then link to the sysinfo in this form:

# sysinfo.abCdE1234.tar.gz
# https://github.com/linuxwacom/wacom-hid-descriptors/issues/1234

A git grep sysinfo will show how this is currently used in existing data files.

See also https://github.com/linuxwacom/libwacom/wiki/Adding-a-new-device


This is an automated comment created by a bot. Responding to the bot or mentioning it won't have any effect.

@olivgat
Copy link
Contributor Author

olivgat commented Dec 23, 2023

Thanks for the feedback whot.

Someone already submitted a report for strictly the same model as mine : linuxwacom/wacom-hid-descriptors#325

Can I reference this issue in my tablet file ? Or do I have to create my own issue on hid-descriptors (with my own sysinfo tarball) ?

@whot
Copy link
Member

whot commented Jan 3, 2024

you can reference that file, we only care about having the data linked to the device for potential future debugging, not who collected it :)

@olivgat olivgat force-pushed the wacom-hid-5362-support branch from d074e12 to b2596b0 Compare January 5, 2024 04:21
@olivgat olivgat force-pushed the wacom-hid-5362-support branch from b2596b0 to aae4280 Compare January 5, 2024 04:54
@whot
Copy link
Member

whot commented Jan 5, 2024

Looks like the test-tablet-validity test (part of meson test -C builddir) still fails, I can't immediately see the issue with the tablet file but the meson logs may have more.

@olivgat
Copy link
Contributor Author

olivgat commented Jan 5, 2024

Looks like the test-tablet-validity test (part of meson test -C builddir) still fails, I can't immediately see the issue with the tablet file but the meson logs may have more.

The culprit was this line in the log :

# Start of 3583 tests
not ok 339 /tablet/class/3583/056a:5362-Wacom HID 5362 Pen,Wacom HID 5362 Finger

I have added the Class parameter in my file and the test is now ok locally. I'm pushing my change to check if the workflow is ok too.

@olivgat olivgat force-pushed the wacom-hid-5362-support branch from aae4280 to 3a94a5d Compare January 5, 2024 05:22
@whot
Copy link
Member

whot commented Jan 5, 2024

I just fixed the sysinfo check in #623, can you please rebase on top of that? Thanks.

@olivgat olivgat force-pushed the wacom-hid-5362-support branch from 3a94a5d to b40a001 Compare January 5, 2024 18:53
@olivgat olivgat force-pushed the wacom-hid-5362-support branch from b40a001 to 1b78c87 Compare January 5, 2024 18:55
@whot whot merged commit bb2c73d into linuxwacom:master Jan 7, 2024
12 of 13 checks passed
@olivgat olivgat deleted the wacom-hid-5362-support branch January 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sysinfo needed Used to indicate sysinfo is missing from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants