Drop the superfluous Buttons entry in the tablet files #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whot
force-pushed
the
wip/drop-buttons
branch
from
3b07aa6 to
9ab319a
Compare
whot
force-pushed
the
wip/drop-buttons
branch
from
9ab319a to
123672b
Compare
Let's infer that data from the [Buttons] group - we require every tablet with buttons to define that group anyway.
whot
force-pushed
the
wip/drop-buttons
branch
from
123672b to
dd699d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIRC this entry dates back to very early versions before we added the separate
Buttonssection. It's superfluous though, the number of buttons can be inferred from that section.Sits on top of #594 but it's technically unrelated to that.