Switch strcmp to g_str_equal()

The latter is less errorprone for equality comparisons.
linuxwacom · Sep 28, 2023 · 73288ee · 73288ee
1 parent 57f6303
commit 73288ee
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/test/test-tablet-svg-validity.c b/test/test-tablet-svg-validity.c
@@ -69,7 +69,7 @@ class_found (gchar **classes, gchar *value)
 {
 	gchar **ptr = classes;
 	while (*ptr) {
-		if (strcmp (*ptr++, value) == 0)
+		if (g_str_equal (*ptr++, value))
 			return TRUE;
 	}
 
@@ -365,7 +365,7 @@ static void setup_tests(WacomDevice *device)
 	const char *name;
 
 	name = libwacom_get_name(device);
-	if (strcmp(name, "Generic") == 0)
+	if (g_str_equal(name, "Generic"))
 		return;
 
 	add_test(device, test_filename);

diff --git a/test/test-tablet-validity.c b/test/test-tablet-validity.c
@@ -327,7 +327,7 @@ static void setup_tests(WacomDevice *device)
 	WacomClass cls;
 
 	name = libwacom_get_name(device);
-	if (strcmp(name, "Generic") == 0)
+	if (g_str_equal(name, "Generic"))
 		return;
 
 	add_test(device, test_class);

diff --git a/tools/list-compatible-styli.c b/tools/list-compatible-styli.c
@@ -32,6 +32,7 @@
 #include <assert.h>
 #include <libgen.h>
 #include <unistd.h>
+#include <glib.h>
 #include "libwacom.h"
 
 static void
@@ -72,7 +73,7 @@ int main(int argc, char **argv)
 	if (argc > 1) {
 		printf("Usage: %s [--help] - list compatible styli\n",
 		       basename(argv[0]));
-	       return !!(strcmp(argv[1], "--help"));
+	       return g_str_equal(argv[1], "--help");
 	}
 
 	db = libwacom_database_new_for_path(DATABASEPATH);