Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add keyboard shortcut s to toggle sidebar visibility #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tfl
Copy link

@tfl tfl commented Nov 9, 2023

This PR adds a keyboard shortcut s to toggle sidebar visibility

@clefebvre
Copy link
Member

Careful here, many hide(), show() calls are called on the sidebar already, when navigating through groups (for series, VOD etc..) and when toggling fullscreen.

Also, if you add shortcuts you need to add the info in the keyboard shortcuts page.

@tfl
Copy link
Author

tfl commented Nov 30, 2023

I have tried s in all situations I came across (and made sense to me) and never went into any problem(s) - besides, there was a toggle-sidebar shortcut before!

But you are right: it has to be documented! Will try again ;)

@tfl
Copy link
Author

tfl commented Dec 13, 2023

Well, now there is an info bar above the stream. It shows the name of the station and the stream url. Why?
Please! If somebody needs to know the stream URL or the name of the station currently streaming then the information should be available via F1.

@clefebvre clefebvre changed the title Add keyboard shortcut s to toggle sidebar visibility [WIP] Add keyboard shortcut s to toggle sidebar visibility Jun 5, 2024
@lakshminarayananb
Copy link
Contributor

lakshminarayananb commented Dec 1, 2024

@tfl this is a neat feature, I earlier submitted a PR to resize the sidebar, this is simpler and neat. Sad that it is not merged.

I took your code and added in my own logic to it to remove the mpv_top_box as well in the version I personally use. This hides the channel and stream url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants