Preventing Hullcam from ... #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated the camera with it still enabled.
|
In time, perhaps something similar may be affeting #28 ? It worths a investigation. |
|
Wait before accepting this pull request. I found some other borderline situation where the Main Can gets screwed. I will try to locate and fix it too. |
|
thanks, was on my todo list |
…ated the camera with it still enabled - done right this time.
|
This. I think this really fix the problem. Some calls to DeactivateCamera were missing, it was not only in one place - and on that place I used the wrong flag on the first commit. This last commit fixed the problem on the two situations I was bitten. |
|
Thanks, will get this out today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…screwing up the MainCam when the user deactivated the camera with it still enabled.
I found this problem while toying with hullcam on KSP 1.4.5, and confirmed it on KSP 1.12.2.
If you deactivate any camera while using it (with it enabled), the Main Cam gets completely screwed and you need to quit to MainMenu and reload the game to get it fixed - switching Scenes does not help.
Lock the Camera PAW before enabling it, then enable it:
Then deactivate it (instead of disabling it):
This pull request fix it.