Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linuxdeploy log directory rename #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dantti
Copy link
Contributor

@dantti dantti commented Jun 18, 2024

Since I needed linuxdeploy-plugin-qt that had the --exclude-libraries working I make the github workflows run on my fork and and have this issue when using a newer (+my patch) linuxdeploy submodule.

@bjorn
Copy link
Contributor

bjorn commented Jun 19, 2024

For context, this adjustment is necessary in response to linuxdeploy/linuxdeploy@2b73a21.

It's a bit unfortunate the move happened as part of "Improve logging of failed subprocesses", since it makes it very hard to see what the actual improvement was (I couldn't spot it).

@TheAssassin
Copy link
Member

It's a bit unfortunate the move happened as part of "Improve logging of failed subprocesses", since it makes it very hard to see what the actual improvement was (I couldn't spot it).

You're absolutely right about this. This was rushed a bit. It shouldn't be a big deal to use a tool like Meld and diff the old and new code, though.

At any rate, @dantti please rebase this branch, then we can merge it.

@dantti dantti force-pushed the dantti/fix_linuxdeploy_log_include branch 2 times, most recently from 70e3e97 to 90703c8 Compare August 4, 2024 02:04
@dantti dantti force-pushed the dantti/fix_linuxdeploy_log_include branch from 90703c8 to 3d9d609 Compare August 11, 2024 14:45
@dantti dantti force-pushed the dantti/fix_linuxdeploy_log_include branch from 3d9d609 to f5f6ca5 Compare October 17, 2024 13:30
@dantti
Copy link
Contributor Author

dantti commented Oct 17, 2024

@TheAssassin this is ready to be merged, CI is broken due other stuff (which a few are addressed in another PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants