-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce optional quiet mode (move technical output from console to /tmp/debug.log) #1863
Open
tlaurion
wants to merge
4
commits into
linuxboot:master
Choose a base branch
from
tlaurion:introduce_quiet_mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+129
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d containing 'export CONFIG_QUIET_MODE=y' for output comparison between debug, prod and quiet mode Signed-off-by: Thierry Laurion <[email protected]>
…now all passed to LOG (quiet mode doesn't show them and logs them to /tmp/debug.log) Signed-off-by: Thierry Laurion <[email protected]>
Signed-off-by: Thierry Laurion <[email protected]>
…l information can be seen running 'cat /tmp/debug.log' from Recovery Shell Signed-off-by: Thierry Laurion <[email protected]>
tlaurion
added
enhancement
UX
release cycle - 2024-11-20
consultation service
Funded work
automated testing
input for docs
debug
labels
Nov 27, 2024
Current PR state videos ( as of a9c3284 ) TLDR default boot screenshot of console output:Videos:
The "technical output" redirected to /tmp/debug.log per same commit:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiP
qemu-coreboot-fbwhiptail-tpm2-hotp-prod_quiet board addition
qemu-coreboot-fbwhiptail-tpm2-hotp-prod_quiet
for building a coreboot ROM that works in the QEMU emulator with graphical mode support, HOTP support, TPM2 integration but runs in prod+quiet mode.Logging Improvements:
LOG()
function ininitrd/etc/ash_functions
to handle different logging modes based onCONFIG_QUIET_MODE
andCONFIG_DEBUG_OUTPUT
settings. This ensures that logs are directed to the appropriate output (console or debug log) based on the configuration.initrd/etc/ash_functions
,initrd/init
,initrd/sbin/insmod
) to use the updatedLOG()
function for consistent logging behavior. This includes logging TPM-related messages and other debug information. [1] [2]Initialization Script Updates:
initrd/init
to inform users when quiet mode is enabled, directing them to check the debug log for technical output.initrd/init
by adding error redirection togrep
commands to avoid unnecessary output.TODOs:
Notes: OEM can add quiet mode as part of their rebranding prior of releases.
WiP demo:
Current state of output (videos and /tmp/debug.log content) at #1863 (comment)