refactor: translate command line arguments into JSON format and use common functions #55
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
trgill
force-pushed
the
use_json
branch
3 times, most recently
from
fa46725 to
cb231b7
Compare
also document snapshot_lvm_mount_options and note that XFS won't allow an identical snapshot to be mounted while the origin is still mounted unless the nouuid option is used. Signed-off-by: Todd Gill <[email protected]>
trgill
force-pushed
the
use_json
branch
2 times, most recently
from
a417467 to
939244d
Compare
|
I'll note that a lot of the code to convert things to/from JSON string, and to perform argument validation, will either go away or be much simpler when this code is converted into an Ansible module |
Ok. That is what I'm planning next. I should have done the module work first. |
Yeah, sorry about that - it didn't occur to me until I realized there were a lot of json/validation changes in this PR |
| lv = list_item["lv"] | ||
| except KeyError: | ||
| vg = None | ||
| lv = None |
Check notice
Code scanning / CodeQL
Unused local variable Note
|
[citest] |
trgill
force-pushed
the
use_json
branch
2 times, most recently
from
bf05cc9 to
e174cbe
Compare
|
[citest] |
trgill
force-pushed
the
use_json
branch
2 times, most recently
from
a2278b2 to
82ff567
Compare
|
[citest] |
…ation minor update to error message for missing LV/VG test update tests for required parameter to umount Signed-off-by: Todd Gill <[email protected]>
|
[citest] |
refactor: use common function for both command line arguments and JSON requests
Issue Tracker Tickets (Jira or BZ if any):
#44
#51