refactor: centralize test setup/cleanup - add cleanup debugging #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
force-pushed
the
debug-cleanup-failures
branch
from
b52717f to
bb3ed66
Compare
richm
changed the title
|
[citest] |
spetrosi
approved these changes
Feb 16, 2024
|
[citest] |
We are getting some test flakes which I believe are related to incomplete cleanup. Rather than add the same code to every test, I created a tasks/cleanup.yml to do this, and variables for the storage pools and other parameters to cleanup. Then, it made sense to do the same for setup - tasks/setup.yml Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
debug-cleanup-failures
branch
from
479a999 to
5cbc04d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting some test flakes which I believe are related to
incomplete cleanup. Rather than add the same code to every test,
I created a tasks/cleanup.yml to do this, and variables for the
storage pools and other parameters to cleanup. Then, it made
sense to do the same for setup - tasks/setup.yml
Signed-off-by: Rich Megginson [email protected]