fix: add timeout for registrar service - use 30 second timeout for registrar and verifier #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gistrar and verifier Cause: The registrar service can fail, but the Ansible service reports success. Consequence: The user does not know that the registrar was mis-configured. Fix: Check the registrar ip and port to ensure they become available. Use a 30 second timeout for both the verifier and registrar as the default 300 seconds for the `wait_for` module is too long. Result: Users are notified in a timely manner if the services failed to start. Signed-off-by: Rich Megginson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: The registrar service can fail, but the Ansible service reports success.
Consequence: The user does not know that the registrar was mis-configured.
Fix: Check the registrar ip and port to ensure they become available. Use a 30
second timeout for both the verifier and registrar as the default 300 seconds for
the
wait_formodule is too long.Result: Users are notified in a timely manner if the services failed to start.
Signed-off-by: Rich Megginson [email protected]