Fix automated (vmchecker) testing for network assignments #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnments Assignment testing is done automatically via vmchecker. This is done with the help of the `so2-startup-script` placed in `/etc/init.d/so2` and then symlinked in `/etc/rcX.d/99so2` (X = 1..6). For networking assignments (i.e. the STP - Simple Transport Protocol), two issues prevent proper testing: 1. Because there is no terminal, standard file descriptors (0, 1, 2) are not initialized. If no redirection is used, then these file descriptors (0, for example) will be used for socket descriptors. Tests for socket() calls assume returned socket file descriptors are > 0. This is fixed by redirecting standard input from `/dev/null`, thus initializing the standard input file descriptor (0). 2. The loopback interface is not initialized. Tests using send/receive calls fails. This is fixed by enabling the loopback interface (`lo`). Signed-off-by: Razvan Deaconescu <[email protected]>
razvand
added
assignments
dbaluta
approved these changes
May 15, 2021
consra
reviewed
May 15, 2021
consra
approved these changes
May 15, 2021
Sergiu121
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment testing is done automatically via vmchecker. This is done
with the help of the
so2-startup-scriptplaced in/etc/init.d/so2and then symlinked in
/etc/rcX.d/99so2(X = 1..6).For networking assignments (i.e. the STP - Simple Transport Protocol),
two issues prevent proper testing:
Because there is no terminal, standard file descriptors (0, 1, 2) are
not initialized. If no redirection is used, then these file descriptors
(0, for example) will be used for socket descriptors. Tests for socket()
calls assume returned socket file descriptors are > 0. This is fixed by
redirecting standard input from
/dev/null, thus initializing thestandard input file descriptor (0).
The loopback interface is not initialized. Tests using send/receive
calls fails. This is fixed by enabling the loopback interface (
lo).Issue 1 could be fixed by updating the test and not redirecting input from
/dev/null. What do you think is the best way to handle this?