CI: Split production and test releases into different jobs + disable attestation for production releases #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jluebbe
requested changes
Nov 4, 2024
In workflow https://github.com/linux-automation/usbsdmux/actions/runs/11659598753/job/32460446373 we have seen that a dirty environment can be problematic for a workflow. Here a leftover file from the publish to test.pypi.org caused the preflight checks for the proper release to fail. With this change we will use different jobs for both steps - thus starting with a clean environment every time. Signed-off-by: Chris Fiege <[email protected]>
With v1.11.0 gh-action-pypi-publish has switched on attestations by default: https://github.com/pypa/gh-action-pypi-publish/releases/tag/v1.11.0 According to it's README they are still beta: https://github.com/pypa/gh-action-pypi-publish/blob/fb13cb306901256ace3dab689990e13a5550ffaa/README.md?plain=1#L102 So we will disable attestations for releases to production for now. This way we can still evaluate this supply chain feature in testing, but keep our stable release workflow more stable. Attestations can be enabled for production once they are stable. Signed-off-by: Chris Fiege <[email protected]>
SmithChart
force-pushed
the
disable-attestations
branch
from
5b6a79c
to
c5447a6
Compare
jluebbe
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.