CI: add automatic publication to pypi.org and test.pypi.org #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to reduce the potential for human error in our publication process and also streamline the process for everyone with the permission to create tags in the repository. The CI job runs for new commits pushed to the master branch and newly pushed tags, as long as the PUBLISH_PYPI GitHub Action variable is set to "true". This is to prevent CI runs on forked repository from failing because they are not allowed to publish on pypi.org and test.pypi.org. A fork that wants to use the publish logic just has to set the PUBLISH_PYPI variable for their repository. The job does not check out the git repository (hence why it does not use the existing publication logic in the Makefile) and instead downloads the artifacts generated by the build job. All builds are uploaded to test.pypi.org (so they can be tested via pip install) and tagged releases are uploaded to pypi.org as well. Also remove the upload helpers from the Makefile to make it clear that they are replaced by the automated process. Signed-off-by: Leonard Göhrs <[email protected]>
SmithChart
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing software manually is a (somewhat) error-prone and (somewhat) tedious process, hence why other projects have already automated this process.
Let's join these other projects and also automate our publication process!
The setup process is surprisingly straight forward and involves setting up trusted publishing on both pypi.org, as well as test.pypi.org. See linux-automation/lxa-iobus#46 for an example on how to do that.
The job also requires a Github Action variable to be set to run (to prevent it from running for forks - for which the publication step would fail due to insufficient permissions). Also see linux-automation/lxa-iobus#46 for an example on how to do that.
TODO before merging:
Both of these PRs should be merged before this one.