make StaticFileWeblet to be concurrency safe #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A weblet instance can be run multiple times at the same time, so payload can not be stored in weblet instance for potential concurrency issue. to fix the issue, precreate a number of payload, as many as web handlers.
|
@linsong - this has been pending for a while. If you can rebase this with master, I can help review/ merge it. Also, now that docs are available, it may make sense to add a page (.md file) about this community module. With the standard commands in |
|
Yeah, I will write a markdown doc about this kit later, and push to the
same branch for review, thanks.
…On Sun, Apr 12, 2020 at 8:09 AM divisuals ***@***.***> wrote:
@linsong <https://github.com/linsong> - this has been pending for a
while. If you can rebase this with master, I can help review/ merge it.
Also, now that docs are available, it may make sense to add a page (.md
file) about this community module. With the standard commands in adm/, I
can't seem to build the kit, so any instructions would help. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIZMJN4FPB32QM474MM3TRMEBCJANCNFSM4HN5ZFYA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A weblet instance can be run multiple times at the same time, so payload
can not be stored in weblet instance for potential concurrency issue.
to fix the issue, precreate a number of payload, as many as web handlers.