Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(async): revert back to previous version 'async' module #258

Merged
merged 5 commits into from
Jan 18, 2025

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Jan 18, 2025

Fix #257

Regression Test

Platforms

  • windows
  • macOS
  • linux

Hosts

Functions

  • Use GitLink(!) to copy git link (or open in browser).
  • Use GitLink(!) blame to copy the /blame link (or open in browser).
  • Use GitLink(!) default_branch to open the /main//master link in browser (or open in browser).
  • Use GitLink(!) current_branch to open the current branch link in browser (or open in browser).
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.
  • Copy git link with 'file' and 'rev' parameters.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 60.76923% with 51 lines in your changes missing coverage. Please review.

Project coverage is 72.89%. Comparing base (df0c4e3) to head (d6e7b38).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lua/gitlinker/async.lua 59.82% 47 Missing ⚠️
lua/gitlinker.lua 66.66% 2 Missing ⚠️
lua/gitlinker/linker.lua 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   73.96%   72.89%   -1.07%     
==========================================
  Files           9       10       +1     
  Lines         845      963     +118     
==========================================
+ Hits          625      702      +77     
- Misses        220      261      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 merged commit bc27701 into master Jan 18, 2025
8 checks passed
@linrongbin16 linrongbin16 deleted the fix-async branch January 18, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: assertion failed! when trying to copy a link
1 participant