Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update docs and dependencies #245

Merged
merged 11 commits into from
Sep 19, 2024
Merged

chore: Update docs and dependencies #245

merged 11 commits into from
Sep 19, 2024

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Aug 20, 2024

Regression Test

Platforms

  • windows
  • macOS
  • linux

Hosts

Functions

  • Use GitLink(!) to copy git link (or open in browser).
  • Use GitLink(!) blame to copy the /blame link (or open in browser).
  • Use GitLink(!) default_branch to open the /main//master link in browser (or open in browser).
  • Use GitLink(!) current_branch to open the current branch link in browser (or open in browser).
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.
  • Copy git link with 'file' and 'rev' parameters.

@linrongbin16
Copy link
Owner Author

The plugin works correctly now, I feel like I should not update it if not necessary.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (542f517) to head (bd4c53f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   72.13%   74.97%   +2.83%     
==========================================
  Files           9        9              
  Lines         847      847              
==========================================
+ Hits          611      635      +24     
+ Misses        236      212      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 reopened this Sep 19, 2024
@linrongbin16
Copy link
Owner Author

linrongbin16 commented Sep 19, 2024

We need to merge this PR (upgrade the commons library) before merge #246 .

@linrongbin16
Copy link
Owner Author

Have no idea why the code coverage report is failed to generate in CI pipeline (lua toolchain is just so weak), let's skip it.

@linrongbin16 linrongbin16 merged commit a71ac7d into master Sep 19, 2024
6 checks passed
@linrongbin16 linrongbin16 deleted the upgrade-commons branch September 19, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant