Fix python 3.13 deprecation of typing.re #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In python 3.13, `typing.re` was removed (deprecated since Python 3.8). See python/cpython#92871 This pr refactors to support python 3.13 which currently throws ```python ImportError: cannot import name 're' from 'typing' ```
|
Ok, I think that last commit should work - @sierra-moxon can you trigger the CI? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
- Coverage 63.43% 4.59% -58.84%
==========================================
Files 63 60 -3
Lines 8982 8088 -894
Branches 2574 2147 -427
==========================================
- Hits 5698 372 -5326
- Misses 2665 7716 +5051
+ Partials 619 0 -619 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 3.13,
typing.rewas removed (deprecated since Python 3.8). See python/cpython#92871This pr refactors to support python 3.13 which currently throws