Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[schemaview][bug] Pass imports as kwarg to all_slots #317

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

sneakers-the-rat
Copy link
Contributor

@sneakers-the-rat sneakers-the-rat commented Mar 27, 2024

phew! +1 to the need for #316

#313 changed the if/else switch in selecting ordering to raise an exception for an unknown value rather than fall through because doing so exposes bugs like this one!

specifically, the docgen tests were all failing on a call to slot_children because they were passing imports as a positional argument rather than a kwarg. Looking for all usages between linkml_runtime and linkml for the two methods all_slots and all_classes that call ordered, and this looks like the only time that happens, everywhere else passes nothing or passes kargs

bonus! now we honor that imports param :)

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.70%. Comparing base (ed36311) to head (0f99716).
Report is 1 commits behind head on main.

Files Patch % Lines
linkml_runtime/utils/schemaview.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   62.70%   62.70%           
=======================================
  Files          63       63           
  Lines        8580     8580           
  Branches     2444     2444           
=======================================
  Hits         5380     5380           
  Misses       2583     2583           
  Partials      617      617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmungall cmungall merged commit b01abb4 into linkml:main Mar 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants