[schemaview][bug] Pass imports
as kwarg to all_slots
#317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phew! +1 to the need for #316
#313 changed the if/else switch in selecting ordering to raise an exception for an unknown value rather than fall through because doing so exposes bugs like this one!
specifically, the
docgen
tests were all failing on a call toslot_children
because they were passing imports as a positional argument rather than a kwarg. Looking for all usages betweenlinkml_runtime
andlinkml
for the two methodsall_slots
andall_classes
that callordered
, and this looks like the only time that happens, everywhere else passes nothing or passes kargsbonus! now we honor that
imports
param :)