Fix namespaces CURIE prefix & suffix extraction #308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation Behind This
While working on the LinkML JSON-LD Context generator, I chose to use the namespaces.py
prefix_suffix(..)
method to build@id
attributes.Then, I started having issues with the test_curie_prefix_matching.py test class (BTW thanks to the developer of this class 👍 ) which has very specific CURIEs like
p1:/c/c1
for example.Solution
I went through the CURIE specification to find which types of CURIEs should be supported and I added them to the
test_namespaces.py
test class to make sure specific cases were managed.The solution I propose is straightforward but as this method is used in many places, the impacts can be big. I have a pull request coming up to update the LinkML project with my JSON-LD Context generator developments and test updates.