Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespaces CURIE prefix & suffix extraction #308

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

vincentkelleher
Copy link

@vincentkelleher vincentkelleher commented Mar 15, 2024

Motivation Behind This

While working on the LinkML JSON-LD Context generator, I chose to use the namespaces.py prefix_suffix(..) method to build @id attributes.

Then, I started having issues with the test_curie_prefix_matching.py test class (BTW thanks to the developer of this class 👍 ) which has very specific CURIEs like p1:/c/c1 for example.

Solution

I went through the CURIE specification to find which types of CURIEs should be supported and I added them to the test_namespaces.py test class to make sure specific cases were managed.

The solution I propose is straightforward but as this method is used in many places, the impacts can be big. I have a pull request coming up to update the LinkML project with my JSON-LD Context generator developments and test updates.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.91%. Comparing base (27b9158) to head (d409e57).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   62.88%   62.91%   +0.02%     
==========================================
  Files          62       62              
  Lines        8528     8528              
  Branches     2436     2436              
==========================================
+ Hits         5363     5365       +2     
+ Misses       2554     2553       -1     
+ Partials      611      610       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmungall cmungall merged commit 90215d2 into linkml:main Mar 18, 2024
9 checks passed
@vincentkelleher
Copy link
Author

Thanks @cmungall 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants