-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate loaders #305
Open
sneakers-the-rat
wants to merge
5
commits into
linkml:main
Choose a base branch
from
sneakers-the-rat:consolidate-loaders
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Consolidate loaders #305
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9456cd8
Add functionality from main linkml to loaders
sneakers-the-rat 36b7298
Imports and passthrough loader
sneakers-the-rat b5f51d2
dummy commit to get github to notice branch
sneakers-the-rat c3ee1a4
remove dummy commit, github finally saw it
sneakers-the-rat 0bd751f
merge main
sneakers-the-rat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
from typing import Any, Iterator | ||
|
||
from linkml_runtime.loaders.loader_root import Loader | ||
|
||
|
||
class PassthroughLoader(Loader): | ||
"""A loader that passes through from an existing Iterator | ||
|
||
:param source: An Iterator | ||
""" | ||
|
||
def __init__(self, source: Iterator) -> None: | ||
super().__init__(source) | ||
|
||
def iter_instances(self) -> Iterator[Any]: | ||
"""Pass through instances from an Iterator | ||
|
||
:return: Iterator over data instances | ||
:rtype: Iterator[Any] | ||
""" | ||
yield from self.source | ||
|
||
def load_any(self, *args, **kwargs): | ||
raise NotImplementedError('Passthrough loader doesnt actually load anything') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor: can be iterated on in new PR]
Can we clarify what a data instance would be?
It seems that this is canonically a dict, never an instance of a class (whether dataclass or pydantic)? or would it be (e.g. pkl serialization)? Would rdflib_loader eventually implement this with a Triple/Quad object, or a 3-or-4-tuple?
I'm tending towards a more predictable signature (iterates over dicts) with some guarantees
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally - so the type annotation here would be refined in the child loaders, keeping it "any" here is just to say "there will be some iterator (it could actually just be
Iterator
and then we would doIterator[dict[str, JsonObj | dict | list]]
or whatever in the child objects. We would make this type a union of all the child types but it wouldn't really give us much bc the child impl should override it