Improve date testing #299
Closed
Improve date testing #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to validate that "greenlet" is on a version that makes the project runnable on Python v3.12. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Prefixmaps requires Python > 3.9.0, therefore also updating the required Python version. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
XSD-date cannot be written in the form "CCYYMMDD", this patch adds a test to ensure it. linkml-runtime has been relying on Python `fromisoformat` [1] format to parse and, implicitly validate, XSD-date. But from Python 3.11 upwards `fromisoformat` also accepts "CCYYMMDD" as a valid date, breaking XSD-date compatibility. This is a regression test to avoid this issue in the future. [1]: https://docs.python.org/3/library/datetime.html#datetime.date.fromisoformat Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 62.80% 62.88% +0.08%
==========================================
Files 61 62 +1
Lines 8506 8531 +25
Branches 2239 2436 +197
==========================================
+ Hits 5342 5365 +23
- Misses 2553 2556 +3
+ Partials 611 610 -1 ☔ View full report in Codecov by Sentry. |
XSD-date cannot be written in the form "CCYYMMDD", this patch adds a test to ensure it. linkml-runtime has been relying on Python `fromisoformat` [1] format to parse and, implicitly validate, XSD-date. But from Python 3.11 upwards `fromisoformat` also accepts "CCYYMMDD" as a valid date, breaking XSD-date compatibility. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.