Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Grass Sass compiler as a fallback #123

Merged
merged 4 commits into from
Jan 25, 2025
Merged

Conversation

theridane
Copy link
Contributor

This adds support for an alternate Sass compiler using import-time detection, and also fixes a failure to find sass if it's in a weird location (but still in PATH).

I'm packaging Ignis for Gentoo and this was easier than bringing in the Dart ecosystem, which, turns out, is completely missing on Gentoo.

ignis/utils/sass.py Outdated Show resolved Hide resolved
@theridane
Copy link
Contributor Author

Like this? The Utils.sass_compile now exposes the compiler selection, compilers are enumerated at import time, the type hint is used as a source of truth during enumeration.

ignis/utils/sass.py Outdated Show resolved Hide resolved
ignis/app.py Show resolved Hide resolved
@linkfrg
Copy link
Owner

linkfrg commented Jan 25, 2025

Run ruff format to fix code formatting

overall everything looks good

Copy link
Owner

@linkfrg linkfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@linkfrg linkfrg merged commit 0756e2f into linkfrg:main Jan 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants