-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow gtk css priority to be overridden #116
Conversation
5ad5c53
to
7101da2
Compare
7101da2
to
9cdc429
Compare
9cdc429
to
f5af290
Compare
I was thinking, what is the point of |
f5af290
to
c89421e
Compare
Removed I think the only thing would be that it would allow setting the priority for both the global style and the widgets at once, but now that you mention it, I doubt that would be better than explicitly setting it where it is needed. |
Hmm, wait. I didn't think about the global style priority for all widgets, sorry. |
c89421e
to
f5af290
Compare
Reverted. Thank goodness for git's reflog.
It's alright. If anything, I share at least partial blame for jumping the gun a bit. |
…ocstrings; set default value of style_priority argument to 'application'
Sorry I just realized I entirely missed the part were you were asking for changes past reverting removing
Just to be clear, if I understand correctly, I should rename |
Okay, I will do rest of stuff by myself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Thank you! |
My GTK theme heavily relies on
~/.config/gtk-4.0/gtk.css
and as a result, it takes precedence over whatever styling I set for Ignis. I cannot find a way around this.This PR adds a read-write property called
gtk_priority
toIgnisApp
so that Ignis's GTK styling priority could be overridden to, say,Gtk.STYLE_PROVIDER_PRIORITY_USER
. Currently, it defaults to the original value,Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION.
Also, I made the
style
attribute inBaseWidget
rely onIgnisApp.gtk_priority
for consistency.