build(deps): bump linkerd/dev from v43 to v44 (#13428)

* docker.io/library/golang from 1.22 to 1.23 * gotestsum from 0.4.2 to 1.12.0 * protoc-gen-go from 1.28.1 to 1.35.2 * protoc-gen-go-grpc from 1.2 to 1.5.1 * docker.io/library/rust from 1.76.0 to 1.83.0 * cargo-deny from 0.14.11 to 0.16.3 * cargo-nextest from 0.9.67 to 0.9.85 * cargo-tarpaulin from 0.27.3 to 0.31.3 * just from 1.24.0 to 1.37.0 * yq from 4.33.3 to 4.44.5 * markdownlint-cli2 from 0.10.0 to 0.15.0 * shellcheck from 0.9.0 to 0.10.0 * actionlint from 1.6.26 to 1.7.4 * protoc from 3.20.3 to 29.0 * step from 0.25.2 to 0.28.2 * kubectl from 1.29.2 to 1.31.3 * k3d from 5.6.0 to 5.7.5 * k3s image shas * helm from 3.14.1 to 3.16.3 * helm-docs from 1.12.0 to 1.14.2
linkerd · Dec 6, 2024 · 17b2692 · 17b2692
1 parent 683ce40
commit 17b2692
Show file tree

Hide file tree

Showing 47 changed files with 487 additions and 1,449 deletions.
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -1,6 +1,6 @@
 {
     "name": "linkerd2",
-    "image": "ghcr.io/linkerd/dev:v43",
+    "image": "ghcr.io/linkerd/dev:v44",
     // "dockerFile": "./Dockerfile",
     // "context": "..",
     "features": {

diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml
@@ -14,13 +14,13 @@ jobs:
     runs-on: ubuntu-22.04
     timeout-minutes: 10
     steps:
-      - uses: linkerd/dev/actions/setup-tools@v43
+      - uses: linkerd/dev/actions/setup-tools@v44
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: just-dev lint-actions
 
   devcontainer-versions:
     runs-on: ubuntu-22.04
     steps:
-      - uses: linkerd/dev/actions/setup-tools@v43
+      - uses: linkerd/dev/actions/setup-tools@v44
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: just-dev check-action-images
diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml
@@ -14,7 +14,7 @@ jobs:
     timeout-minutes: 30
     runs-on: ubuntu-22.04
     container:
-      image: golang:1.22
+      image: golang:1.23
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: go install gotest.tools/[email protected]
@@ -51,7 +51,7 @@ jobs:
     runs-on: ubuntu-22.04
     timeout-minutes: 15
     container:
-      image: docker://rust:1.76.0
+      image: docker://rust:1.83.0
       options: --security-opt seccomp=unconfined
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683

diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -38,7 +38,7 @@ jobs:
     steps:
       - uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed
         with:
-          go-version: "1.22"
+          go-version: "1.23"
       - name: Checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
 

diff --git a/.github/workflows/devcontainer.yml b/.github/workflows/devcontainer.yml
@@ -15,7 +15,7 @@ permissions:
 jobs:
   rust-version:
     runs-on: ubuntu-22.04
-    container: ghcr.io/linkerd/dev:v43-rust
+    container: ghcr.io/linkerd/dev:v44-rust
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - shell: bash
@@ -39,6 +39,6 @@ jobs:
   devcontainer-image:
     runs-on: ubuntu-22.04
     steps:
-      - uses: linkerd/dev/actions/setup-tools@v43
+      - uses: linkerd/dev/actions/setup-tools@v44
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: just-dev pull-dev-image
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -29,7 +29,7 @@ jobs:
     if: needs.meta.outputs.changed == 'true'
     timeout-minutes: 10
     runs-on: ubuntu-22.04
-    container: ghcr.io/linkerd/dev:v43-go
+    container: ghcr.io/linkerd/dev:v44-go
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: git config --global --add safe.directory "$PWD" # actions/runner#2033
@@ -40,7 +40,7 @@ jobs:
     if: needs.meta.outputs.changed == 'true'
     timeout-minutes: 10
     runs-on: ubuntu-22.04
-    container: ghcr.io/linkerd/dev:v43-go
+    container: ghcr.io/linkerd/dev:v44-go
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: git config --global --add safe.directory "$PWD" # actions/runner#2033
@@ -51,7 +51,7 @@ jobs:
     if: needs.meta.outputs.changed == 'true'
     timeout-minutes: 10
     runs-on: ubuntu-22.04
-    container: ghcr.io/linkerd/dev:v43-go
+    container: ghcr.io/linkerd/dev:v44-go
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: git config --global --add safe.directory "$PWD" # actions/runner#2033

diff --git a/.github/workflows/helm.yml b/.github/workflows/helm.yml
@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-22.04
     timeout-minutes: 5
     steps:
-      - uses: linkerd/dev/actions/setup-tools@v43
+      - uses: linkerd/dev/actions/setup-tools@v44
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: helm-docs
       - run: git diff --exit-code -- **/charts/**/README.md
diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml
@@ -10,10 +10,10 @@ env:
   CARGO_NET_RETRY: 10
   DOCKER_REGISTRY: ghcr.io/linkerd
   GH_ANNOTATION: true
-  K3D_VERSION: v5.4.4
+  K3D_VERSION: v5.7.5
   RUST_BACKTRACE: short
   RUSTUP_MAX_RETRIES: 10
-  YQ_VERSION: v4.25.1
+  YQ_VERSION: v4.44.5
   LINKERD2_PROXY_REPO: ${{ vars.LINKERD2_PROXY_REPO || 'linkerd/linkerd2-proxy' }}
   LINKERD2_PROXY_RELEASE_PREFIX: ${{ vars.LINKERD2_PROXY_RELEASE_PREFIX || 'release/' }}
 
@@ -138,7 +138,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed
         with:
-          go-version: "1.22"
+          go-version: "1.23"
       - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16
         with:
           pattern: image-archives-*
@@ -265,7 +265,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed
         with:
-          go-version: "1.22"
+          go-version: "1.23"
       - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16
         with:
           pattern: image-archives-*
@@ -290,7 +290,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed
         with:
-          go-version: "1.22"
+          go-version: "1.23"
       - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16
         with:
           pattern: image-archives-*
@@ -324,7 +324,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed
         with:
-          go-version: "1.22"
+          go-version: "1.23"
       - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16
         with:
           pattern: image-archives-*

diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml
@@ -15,7 +15,7 @@ jobs:
   proto-diff:
     timeout-minutes: 10
     runs-on: ubuntu-22.04
-    container: ghcr.io/linkerd/dev:v43-go
+    container: ghcr.io/linkerd/dev:v44-go
     steps:
       - run: apt update && apt install -y unzip
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -11,7 +11,7 @@ permissions:
 env:
   GH_ANNOTATION: true
   DOCKER_REGISTRY: ghcr.io/linkerd
-  K3D_VERSION: v5.4.4
+  K3D_VERSION: v5.7.5
   LINKERD2_PROXY_REPO: ${{ vars.LINKERD2_PROXY_REPO }}
 
 jobs:
@@ -98,7 +98,7 @@ jobs:
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed
         with:
-          go-version: "1.22"
+          go-version: "1.23"
       - name: Download image archives
         uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16
         with:
@@ -130,7 +130,7 @@ jobs:
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed
         with:
-          go-version: "1.22"
+          go-version: "1.23"
       - name: Set environment variables from scripts
         run: |
           TAG='${{ needs.tag.outputs.tag }}'

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -43,7 +43,7 @@ jobs:
   fmt:
     timeout-minutes: 5
     runs-on: ubuntu-22.04
-    container: ghcr.io/linkerd/dev:v43-rust
+    container: ghcr.io/linkerd/dev:v44-rust
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: git config --global --add safe.directory "$PWD" # actions/runner#2033
@@ -52,7 +52,7 @@ jobs:
   clippy:
     timeout-minutes: 20
     runs-on: ubuntu-22.04
-    container: ghcr.io/linkerd/dev:v43-rust
+    container: ghcr.io/linkerd/dev:v44-rust
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: git config --global --add safe.directory "$PWD" # actions/runner#2033
@@ -63,7 +63,7 @@ jobs:
   check:
     timeout-minutes: 20
     runs-on: ubuntu-22.04
-    container: ghcr.io/linkerd/dev:v43-rust
+    container: ghcr.io/linkerd/dev:v44-rust
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: git config --global --add safe.directory "$PWD" # actions/runner#2033
@@ -74,7 +74,7 @@ jobs:
     name: test
     runs-on: ubuntu-22.04
     timeout-minutes: 15
-    container: ghcr.io/linkerd/dev:v43-rust
+    container: ghcr.io/linkerd/dev:v44-rust
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: git config --global --add safe.directory "$PWD" # actions/runner#2033

diff --git a/.github/workflows/shell.yml b/.github/workflows/shell.yml
@@ -16,6 +16,6 @@ jobs:
     timeout-minutes: 10
     runs-on: ubuntu-22.04
     steps:
-      - uses: linkerd/dev/actions/setup-tools@v43
+      - uses: linkerd/dev/actions/setup-tools@v44
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - run: just sh-lint
diff --git a/.golangci.yml b/.golangci.yml
@@ -7,15 +7,15 @@
 
 run:
   deadline: 5m
-  skip-dirs:
+  exclude-dirs:
   - controller/gen
 
 linters:
   enable:
   - bodyclose
+  #TODO - copyloopvar
   - errcheck
   - errorlint
-  - exportloopref
   - gocritic
   - gosec
   - gosimple
@@ -41,9 +41,7 @@ linters:
   # - maligned
   # - prealloc
 
-  disable:
-  # https://github.com/golangci/golangci-lint/issues/2649
-  - structcheck
+  disable: []
 
 linters-settings:
   revive:
@@ -52,6 +50,14 @@ linters-settings:
       disabled: true
   stylecheck:
     checks: ["ST1019"]
+  errcheck:
+    exclude-functions:
+      - fmt.Fprint
+      - fmt.Fprintf
+      - fmt.Fprintln
+  gosec:
+    excludes:
+      - G115 # Potential integer overflow when converting between integer types
 
 issues:
   exclude-use-default: false

diff --git a/Dockerfile-proxy b/Dockerfile-proxy
@@ -2,7 +2,7 @@ ARG RUNTIME_IMAGE=gcr.io/distroless/cc-debian12
 ARG BUILDPLATFORM=linux/amd64
 
 # Precompile key slow-to-build dependencies
-FROM --platform=$BUILDPLATFORM golang:1.22-alpine AS go-deps
+FROM --platform=$BUILDPLATFORM golang:1.23-alpine AS go-deps
 WORKDIR /linkerd-build
 COPY go.mod go.sum ./
 COPY bin/install-deps bin/

diff --git a/bin/k3d b/bin/k3d
@@ -2,7 +2,7 @@
 
 set -eu
 
-K3D_VERSION=v5.4.3
+K3D_VERSION=v5.7.5
 
 bindir=$( cd "${0%/*}" && pwd )
 

diff --git a/charts/linkerd-control-plane/README.md b/charts/linkerd-control-plane/README.md
@@ -48,6 +48,9 @@ Note that the provided certificates must be ECDSA certificates.
 
 ## Adding Linkerd's Helm repository
 
+Included here for completeness-sake, but should have already been added when
+`linkerd-base` was installed.
+
 ```bash
 # To add the repo for Linkerd edge releases:
 helm repo add linkerd https://helm.linkerd.io/edge
@@ -66,6 +69,9 @@ helm install linkerd-control-plane -n linkerd \
   linkerd/linkerd-control-plane
 ```
 
+Note that you require to install this chart in the same namespace you installed
+the `linkerd-base` chart.
+
 ## Setting High-Availability
 
 Besides the default `values.yaml` file, the chart provides a `values-ha.yaml`
@@ -313,4 +319,4 @@ Kubernetes: `>=1.22.0-0`
 | webhookFailurePolicy | string | `"Ignore"` | Failure policy for the proxy injector |
 
 ----------------------------------------------
-Autogenerated from chart metadata using [helm-docs v1.12.0](https://github.com/norwoodj/helm-docs/releases/v1.12.0)
+Autogenerated from chart metadata using [helm-docs v1.14.2](https://github.com/norwoodj/helm-docs/releases/v1.14.2)
diff --git a/charts/linkerd-crds/README.md b/charts/linkerd-crds/README.md
@@ -70,4 +70,4 @@ Kubernetes: `>=1.22.0-0`
 | enableTlsRoutes | bool | `true` |  |
 
 ----------------------------------------------
-Autogenerated from chart metadata using [helm-docs v1.12.0](https://github.com/norwoodj/helm-docs/releases/v1.12.0)
+Autogenerated from chart metadata using [helm-docs v1.14.2](https://github.com/norwoodj/helm-docs/releases/v1.14.2)
diff --git a/charts/linkerd2-cni/README.md b/charts/linkerd2-cni/README.md
@@ -68,4 +68,4 @@ Kubernetes: `>=1.22.0-0`
 | useWaitFlag | bool | `false` | Configures the CNI plugin to use the -w flag for the iptables command |
 
 ----------------------------------------------
-Autogenerated from chart metadata using [helm-docs v1.12.0](https://github.com/norwoodj/helm-docs/releases/v1.12.0)
+Autogenerated from chart metadata using [helm-docs v1.14.2](https://github.com/norwoodj/helm-docs/releases/v1.14.2)
diff --git a/charts/partials/README.md b/charts/partials/README.md
@@ -6,4 +6,4 @@ depended by the 'linkerd' and 'patch' charts.
 ![Version: 0.1.0](https://img.shields.io/badge/Version-0.1.0-informational?style=flat-square)
 
 ----------------------------------------------
-Autogenerated from chart metadata using [helm-docs v1.12.0](https://github.com/norwoodj/helm-docs/releases/v1.12.0)
+Autogenerated from chart metadata using [helm-docs v1.14.2](https://github.com/norwoodj/helm-docs/releases/v1.14.2)
diff --git a/cli/Dockerfile b/cli/Dockerfile
@@ -1,7 +1,7 @@
 ARG BUILDPLATFORM=linux/amd64
 
 # Precompile key slow-to-build dependencies
-FROM --platform=$BUILDPLATFORM golang:1.22-alpine AS go-deps
+FROM --platform=$BUILDPLATFORM golang:1.23-alpine AS go-deps
 WORKDIR /linkerd-build
 COPY go.mod go.sum ./
 COPY bin/install-deps bin/

diff --git a/controller/Dockerfile b/controller/Dockerfile
@@ -1,7 +1,7 @@
 ARG BUILDPLATFORM=linux/amd64
 
 # Precompile key slow-to-build dependencies
-FROM --platform=$BUILDPLATFORM golang:1.22-alpine AS go-deps
+FROM --platform=$BUILDPLATFORM golang:1.23-alpine AS go-deps
 WORKDIR /linkerd-build
 COPY go.mod go.sum ./
 COPY bin/install-deps bin/
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,7 +2,7 @@ @@
     set -eu
-    K3D_VERSION=v5.4.3
+    K3D_VERSION=v5.7.5
     bindir=$( cd "${0%/*}" && pwd )
@@ Expand Down @@